-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1876: Remove the redundant code for fmt.Print #1878
Fix #1876: Remove the redundant code for fmt.Print #1878
Conversation
Hi @MohitKambli Thanks for the contribution! |
7d1a260
to
f6d9698
Compare
Hello @seokho-son, Thanks and Regards, |
Hello @seokho-son, Thanks and Regards, |
Hi @MohitKambli
According to the error messages,
|
src/core/common/config.go
Outdated
@@ -149,10 +149,6 @@ func UpdateConfig(u *model.ConfigReq) (model.ConfigInfo, error) { | |||
} | |||
keyValue, _ := kvstore.GetKv(key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyValue, _ := kvstore.GetKv(key) |
You don't have to reopen this PR, we can handle the issue in this PR. :) |
@MohitKambli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/approve |
Thanks for the contribution! |
Hello @seokho-son, Thanks and Regards, |
@all-contributors please add @MohitKambli for Code |
I've put up a pull request to add @MohitKambli! 🎉 |
@MohitKambli your name is officially listed in https://github.com/cloud-barista/cb-tumblebug?tab=readme-ov-file#contributors- :) |
Hello,
Hope you're doing well
As per the request mentioned in issue #1876, I have simple removed the redundant log statement that has been mentioned
If at all I missed something or implemented code changes incorrectly, then do let me know
Sincere apologies for any inconvenience or misunderstanding
Thanks and Regards,
Mohit Kambli